Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DuckPlayer: Youtube internal navigation fix #3748

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

afterxleep
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1204099484721401/1209009420882148/f
Tech Design URL:
CC:

Description:
Bugfix: When watching a Youtube video (/watch/ page), tapping the buttons in Youtube's top navbar caused the page to reload or DuckPlayer to show, and users were not able to access Youtube's settings.

Since Youtube uses hashes for internal navigation, this allows internal Youtube navigation for all DuckPlayer modes by ignoring URL changes that include a hash (#)

Steps to test this PR:

  1. Set DuckPlayer to 'Always Ask' mode
  2. Go to youtube.com and navigate to a video
  3. Tap the 'Search' or 'Three dot menu' icon at the sites' top navbar
  4. Confirm Youtube's UI is presented and page does not reload or DuckPlayer opens

Demo:
RocketSim_Recording_iPhone_(18 0)_6 1_2024-12-19_16 43 47

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@afterxleep afterxleep requested review from a team and alessandroboron and removed request for a team December 19, 2024 15:45
@afterxleep afterxleep changed the title Update test DuckPlayer: Youtube internal navigation fix Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant