DuckPlayer: Youtube internal navigation fix #3748
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204099484721401/1209009420882148/f
Tech Design URL:
CC:
Description:
Bugfix: When watching a Youtube video (/watch/ page), tapping the buttons in Youtube's top navbar caused the page to reload or DuckPlayer to show, and users were not able to access Youtube's settings.
Since Youtube uses hashes for internal navigation, this allows internal Youtube navigation for all DuckPlayer modes by ignoring URL changes that include a hash (#)
Steps to test this PR:
Demo:
Definition of Done (Internal Only):
Copy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template