Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate new tab creation to WebView #3746

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

bwaresiak
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/856498667320406/1208699273169079/f
Tech Design URL:
CC:

Description:

Delegate new tab creation to WebView.

Steps to test this PR:

  1. Navigate to https://privacy-test-pages.site/privacy-protections/referrer-trimming/
  2. Check for referrer and how tabs behave.

Definition of Done (Internal Only):

Device Testing:

  • iPhone
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17
  • iOS 18

Internal references:

Software Engineering Expectations
Technical Design Template

@bwaresiak bwaresiak requested review from a team, studiosutara and afterxleep and removed request for a team and studiosutara December 19, 2024 13:15
Copy link
Collaborator

@afterxleep afterxleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwaresiak
Copy link
Collaborator Author

Thanks @afterxleep!

@bwaresiak bwaresiak merged commit 26699be into main Dec 20, 2024
23 of 25 checks passed
@bwaresiak bwaresiak deleted the bartek/new-tab-handling branch December 20, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants