Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BrowsingMenu layout #3712

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix BrowsingMenu layout #3712

wants to merge 4 commits into from

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Dec 11, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1208946169184139/f
Tech Design URL:
CC:

Description:

Adjusts layout for BrowsingMenuButton so that it expands along with the label inside. Additionally BrowsingMenuViewController got a new constraint preventing the menu view from going outside view bounds.

Steps to test this PR:

  1. Enable link conditioner with a bad/slow connection profile.
  2. Try to load any site, stop before it finishes loading.
  3. Open menu, check if button titles are visible.
  4. Load site again (without link conditioner).
  5. Check browsing menu sizing and layout is as expected.
  6. Go to System Settings -> Developer -> View (simulator) or Display & Brightness -> Display Zoom (physical device) and set display zoom to "Larger text".
  7. Repeat testing steps.

Definition of Done (Internal Only):

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 requested a review from Bunn December 11, 2024 11:28
Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants