OmniBar.refreshState: Don't layoutIfNeeded if... not needed

[graeme]

Task/Issue URL: https://app.asana.com/0/414709148257752/1208881366194997/f

Description:

OmniBar.refreshState is crashing when called as part of setting up the initial UI stack. It's specifically the layoutIfNeeded call that is crashing so I'm going to see if removing this when initially creating the views has an effect. After all, it shouldn't be needed in that case.

Steps to test this PR:

1. Launch the app a few times, altering the text in the OmniBar each time.
2. Generally try breaking this.

Definition of Done (Internal Only):

• Does this PR satisfy our Definition of Done?

Copy Testing:

• Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

• Portrait
• Landscape

Device Testing:

• iPhone SE (1st Gen)
• iPhone 8
• iPhone X
• iPhone 14 Pro
• iPad

OS Testing:

• iOS 15
• iOS 16
• iOS 17

Theme Testing:

• Light theme
• Dark theme

---

Internal references:

Software Engineering Expectations
Technical Design Template

[samsymons]

Overall this works for me, though I'll leave it to you regarding whether we want to proceed with this change since per discussion in Asana it's looking like this crash has an unrelated cause.

[github-actions]

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.