Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If haven't any new tabs show alert to open new tabs when tap Bookmark all button [TabView] #3668

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gokulvenkat243
Copy link

@gokulvenkat243 gokulvenkat243 commented Dec 4, 2024

… alert to open new tab

Task/Issue URL: #3667
Tech Design URL:
CC:

Description:
If haven't any tabs show alert to open new tab when tap the add bookmark all button in TabView.

Steps to test this PR:

  1. Open TabView
  2. Tap Bookmark all button
  3. haven't any new tabs, if tap the bookmark all button displayed bookmark in alert then tap the bookmark.
  4. Now displayed add new tab in alert.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 16
  • iPhone X
  • iPhone 15 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant