Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix return user segmentation #3387

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Sep 24, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1208380046395184/f
Tech Design URL:
CC:

Description:
Fix usage segmentation for return users.

Steps to test this PR:

  1. Reset the simulator xcrun simctl erase all

  2. Add the following lines to the start of the load func of StatisticsLoader:

     statisticsStore.variant = "ru"
     statisticsStore.atb = "v446-1"
     statisticsStore.appRetentionAtb = "v447-1"
     statisticsStore.searchRetentionAtb = "v447-2"
    
  3. Run the app and check for a pixel like this:

     Pixel fired m.retention.segments ["count_as_mau_n": "tttt", "new_set_atb": "v448-7", "count_as_wau": "true", "segments_today": "first_month,reactivated_wau,reinstaller", "activity_type": "app_use"]
    
  4. Ensure that reinstaller and "activity_type": "app_use" are in the parameters as above

  5. Get through onboarding and do a search

  6. Check for a similar pixel ensuring that reinstaller and "activity_type": "search" are in the parameters

Definition of Done (Internal Only):

@brindy brindy closed this Sep 24, 2024
@brindy brindy reopened this Sep 24, 2024
@brindy brindy force-pushed the brindy/fix-return-user-segmentation branch from 9c7a2d8 to e60259f Compare September 24, 2024 10:20
@brindy brindy requested a review from aataraxiaa September 24, 2024 10:40
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM @brindy

@brindy brindy merged commit 2d9ec00 into hotfix/7.138.1 Sep 24, 2024
21 checks passed
@brindy brindy deleted the brindy/fix-return-user-segmentation branch September 24, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants