Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add survey to Passwords screen #3327

Merged
merged 15 commits into from
Sep 10, 2024
Merged

Add survey to Passwords screen #3327

merged 15 commits into from
Sep 10, 2024

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Sep 5, 2024

Task/Issue URL: https://app.asana.com/0/1201462886803403/1207935899042226/f
Tech Design URL:
CC:

Description:
Adds support for presenting a survey in the Passwords screen, controlled via privacy config remote feature flag

Steps to test this PR:
Note: Since this change impacts the Sync Promo, there are a few regression test steps included. Also the survey should always take precedence over the Sync Promo.

  1. Update the privacy config to use https://jsonblob.com/api/1191704313704865792
  2. Reset the Sync Promos via the Debug screen (last entry), ensure Sync is disabled and that you have at least 1 password saved
  3. Go to the Passwords screen and confirm the survey is present (it displays regardless of the number of passwords saved so should also show when there are none saved)
  4. Enter Edit mode and confirm the survey is hidden, but re-appears when leaving edit mode
  5. Perform a search and confirm the survey is hidden, but re-appears when finished searching
  6. Tap the “Take Survey” button and confirm the survey loads in a new tab, and that the URL includes the parameter saved_passwords= with a value that corresponds to number of passwords saved as per AutofillSurveyManager.bucketNameFrom(count:)
  7. Go back to the Passwords screen and confirm you now see the Sync Promo
  8. From the Debug > Autofill Settings screen tap “Reset Autofill Surveys” to reset the survey prompt
  9. Go back to the Passwords screen and confirm the survey is visible again
  10. Tap the x button on the survey to dismiss it. Confirm the Sync Promo does not immediately appear
  11. Back out of the Passwords screen and come back in, and confirm you now see the Sync Promo
  12. Tap the “No Thanks” button and confirm there are now no header prompts
  13. Back out of the Passwords screen and come back in, and confirm there are still no header prompts

<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
—>

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 changed the title Survey add to Passwords screen Survey added to Passwords screen Sep 5, 2024
@amddg44 amddg44 changed the title Survey added to Passwords screen Add survey to Passwords screen Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 7782aa4

@amddg44 amddg44 requested a review from aataraxiaa September 5, 2024 16:14
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all looks good @amddg44. I could only find super minor suggestions. Nice one! 🚀

DuckDuckGo/AutofillSurveyManager.swift Outdated Show resolved Hide resolved
DuckDuckGo/AutofillSurveyManager.swift Outdated Show resolved Hide resolved
Base automatically changed from anya/autofill-suvery-feature-flag to main September 9, 2024 09:48
@amddg44 amddg44 changed the base branch from main to release/7.137.0 September 10, 2024 08:15
…ill-survey

# Conflicts:
#	Core/FeatureFlag.swift
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/Debug.storyboard
@amddg44 amddg44 merged commit 93a1189 into release/7.137.0 Sep 10, 2024
13 checks passed
@amddg44 amddg44 deleted the anya/autofill-survey branch September 10, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants