Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pixel measurements for New Tab Page #3210

Merged
merged 12 commits into from
Aug 19, 2024
Merged

Add pixel measurements for New Tab Page #3210

merged 12 commits into from
Aug 19, 2024

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Aug 8, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1207542256913463/f
Tech Design URL:
CC:

Description:

Adds pixels based on https://app.asana.com/0/72649045549333/1207539163549342/f.

Steps to test this PR:

  1. Enable New Tab Page Sections in Debug menu.
  2. Enable Intro Message in Debug menu.
  3. Verify pixels are fired for:
  4. Showing NTP, daily and regular.
  5. Intro message displayed.
  6. Intro message dismissed.
  7. Tapping on favorites placeholder.
  8. Showing favorites tooltip.
  9. Expand and collapse favorites.
  10. Using each shortcut.
  11. Opening NTP settings.
  12. Rearranging sections.
  13. Toggling sections visibility.
  14. Toggling shortcuts visibility.

Definition of Done (Internal Only):


Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 requested a review from brindy August 9, 2024 09:39
@dus7 dus7 marked this pull request as ready for review August 9, 2024 09:40
Copy link

github-actions bot commented Aug 9, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against df78012

Copy link

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Aug 17, 2024
@dus7 dus7 removed the stale label Aug 19, 2024
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for this icon:

image

Feel free to merge if you wanna fix here or it's already fixed somewhere else.

@dus7 dus7 merged commit 8885b42 into main Aug 19, 2024
15 checks passed
@dus7 dus7 deleted the mariusz/ntp-pixels branch August 19, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants