Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependency #3199

Closed
wants to merge 1 commit into from
Closed

Conversation

SabrinaTardio
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414709148257752/1207981214658241/f

Description: Updates BSK dependency

Steps to test this PR:

  1. Check the app compiles

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

SabrinaTardio added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Aug 7, 2024
Task/Issue URL:  https://app.asana.com/0/0/1207981214658241/f
iOS PR:  duckduckgo/iOS#3199
macOS PR:  duckduckgo/macos-browser#3081
What kind of version bump will this require?: Major/Minor/Patch

**Description**: Allows to load early script before rules are compiled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants