Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix New Tab Page UI issues on iOS 15 #3198

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Fix New Tab Page UI issues on iOS 15 #3198

merged 5 commits into from
Aug 7, 2024

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Aug 7, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/72649045549333/1207977496450588/f
Tech Design URL:
CC:

Description:

This PR fixes a bunch of UI issues I've found while running the app on iOS 15, namely:

  • Alignment of editing accessory was out of place, because of differences in sizing inside an overlay (c298f22).
  • List height was not calculated properly with previous approach. I used anchorPreferences which seems to be more reliable at converting into another coordinate space. (29387e7)
  • Leading insets on editable list were weirdly big. (2ee1280)
  • Tint color was not applied for switch in NTP settings view. (66c5888)
  • Adding a gesture to disable scroll had a side effect of disabling all editing interactions. Decided to leave the scroll enabled for iOS 15, since I haven't found any other solution that works reliably inside NavigationView. (53dc255)

Steps to test this PR:

  1. Verify issues mentioned in the description are not present on iOS 15
  2. Check UI looks properly on iOS 16+

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 requested a review from brindy August 7, 2024 08:43
@dus7 dus7 marked this pull request as ready for review August 7, 2024 08:43
brindy
brindy approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on 17.4 and 15.5

@dus7 dus7 merged commit 3ea8fd3 into main Aug 7, 2024
31 checks passed
@dus7 dus7 deleted the mariusz/ntp-ios15 branch August 7, 2024 14:42
samsymons added a commit that referenced this pull request Aug 7, 2024
@samsymons
Merge branch 'main' into sam/vpn-snooze-initial-support
12195f4 
# By Mariusz Śpiewak (7) and others
# Via Diego Rey Mendez (1) and GitHub (1)
* main:
  Bump BSK to 181.1.0 (sets Privacy Dashboard to 5.0.0) (#3166)
  Animate transition between New Tab Page and tab switcher (#3196)
  Fix New Tab Page UI issues on iOS 15 (#3198)
  Push domain exclusions to internal release (#3195)
  Show shortcuts for enabled features only (#3193)
  Translate strings introduced in New Tab Page improvements (#3174)
  Update release workflow to use S3 bucket name from secrets (#3120)
  Handle contingency settings state on remote config (#3190)
  Add UI for displaying Duck Player contingency message #3065 (#3181)
  Open keyboard on New Tab Page based on Settings (#3187)
  Integrated macOS VPN Domain exclusion (internal release) changes into iOS. (#3164)
  Release 7.132.0-0 (#3194)
  Increase testPixelDebouncePreventsFiringWithinInterval test timeout (#3192)
  Update toolbar items for New Tab Page (#3185)
  new pixel and parameter for monitoring clearing of data stores (#3186)
  ensure new data clearing api is being used (#3191)
  If no App Store subscriptions option are available return empty options object (#3188)
  Show Intro message for existing users on New Tab Page (#3173)
  Experiment Contextual onboarding (#3160)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dus7 @brindy