Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure new data clearing api is being used #3191

Merged
merged 1 commit into from
Aug 5, 2024
Merged

ensure new data clearing api is being used #3191

merged 1 commit into from
Aug 5, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Aug 5, 2024

Task/Issue URL: https://app.asana.com/0/392891325557410/1207976962313197/f
Tech Design URL:
CC: @bwaresiak

Description:
Ensure allocation of container id after clearing if on iOS 17 and fix relevant tests.

Steps to test this PR:

  1. Clean app - browse some sites, use the fire button. Container id should be nil when data clearing function is called
  2. Browse some sites and use the fire button. Container id should NOT be nil when data clearing function is called
  3. Browse some sites and use the fire button. Container id should NOT be nil when data clearing function is called and should be different from old one
  4. Ensure tests all pass

@brindy brindy requested a review from miasma13 August 5, 2024 14:42
miasma13
miasma13 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@miasma13 miasma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brindy brindy merged commit 44f9b03 into main Aug 5, 2024
16 checks passed
@brindy brindy deleted the brindy/re-enable-container-clearing branch August 5, 2024 15:09
samsymons added a commit that referenced this pull request Aug 7, 2024
@samsymons
Merge branch 'main' into sam/vpn-snooze-initial-support
12195f4 
# By Mariusz Śpiewak (7) and others
# Via Diego Rey Mendez (1) and GitHub (1)
* main:
  Bump BSK to 181.1.0 (sets Privacy Dashboard to 5.0.0) (#3166)
  Animate transition between New Tab Page and tab switcher (#3196)
  Fix New Tab Page UI issues on iOS 15 (#3198)
  Push domain exclusions to internal release (#3195)
  Show shortcuts for enabled features only (#3193)
  Translate strings introduced in New Tab Page improvements (#3174)
  Update release workflow to use S3 bucket name from secrets (#3120)
  Handle contingency settings state on remote config (#3190)
  Add UI for displaying Duck Player contingency message #3065 (#3181)
  Open keyboard on New Tab Page based on Settings (#3187)
  Integrated macOS VPN Domain exclusion (internal release) changes into iOS. (#3164)
  Release 7.132.0-0 (#3194)
  Increase testPixelDebouncePreventsFiringWithinInterval test timeout (#3192)
  Update toolbar items for New Tab Page (#3185)
  new pixel and parameter for monitoring clearing of data stores (#3186)
  ensure new data clearing api is being used (#3191)
  If no App Store subscriptions option are available return empty options object (#3188)
  Show Intro message for existing users on New Tab Page (#3173)
  Experiment Contextual onboarding (#3160)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miasma13 miasma13 miasma13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brindy @miasma13