Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle contingency settings state on remote config #3190

Merged
merged 8 commits into from
Aug 6, 2024
Merged

Handle contingency settings state on remote config #3190

merged 8 commits into from
Aug 6, 2024

Conversation

Bunn
Copy link
Contributor

@Bunn Bunn commented Aug 5, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/0/1207976963085128/f
Stacked on top of #3181

Description:
Display DuckPlayer contingency message and disable settings if necessary

Steps to test this PR:

  1. Use https://jsonblob.com/api/1269938997861146624 config URL (URL set, Feature ON)
  2. Check if DuckPlayer works (it should), and that the contingency message is not shown
  3. Check that Duck Player settings is not disabled
  1. Use https://jsonblob.com/api/1269944115209822208 config URL (URL set, Feature OFF)
  2. Check if DuckPlayer works (it shouldn't) and that the contingency message is shown
  3. Click on Learn More, check that this link opens
  4. Check that Duck Player settings is disabled
  1. Use https://jsonblob.com/api/1269953336848539648 config URL (URL not set, Feature OFF)
  2. Check if DuckPlayer works (it shouldn't) and that the contingency message is not shown.

@Bunn Bunn mentioned this pull request Aug 5, 2024
Merged
@Bunn Bunn requested a review from afterxleep August 5, 2024 13:04
afterxleep
afterxleep approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@afterxleep afterxleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. This is what I see:

Screenshot 2024-08-06 at 2 47 12 PM

Bunn added 3 commits August 6, 2024 16:57
@Bunn
Merge branch 'main' into bunn/duckplayer/handle-settings
fd209bc 
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/SettingsDuckPlayerView.swift
#	DuckDuckGo/SettingsViewModel.swift
@Bunn
Update BSK
4f6489d
@Bunn
Remove local contingency handler
c1a0a81
@Bunn Bunn merged commit 3206f7d into main Aug 6, 2024
13 checks passed
@Bunn Bunn deleted the bunn/duckplayer/handle-settings branch August 6, 2024 16:24
samsymons added a commit that referenced this pull request Aug 7, 2024
@samsymons
Merge branch 'main' into sam/vpn-snooze-initial-support
12195f4 
# By Mariusz Śpiewak (7) and others
# Via Diego Rey Mendez (1) and GitHub (1)
* main:
  Bump BSK to 181.1.0 (sets Privacy Dashboard to 5.0.0) (#3166)
  Animate transition between New Tab Page and tab switcher (#3196)
  Fix New Tab Page UI issues on iOS 15 (#3198)
  Push domain exclusions to internal release (#3195)
  Show shortcuts for enabled features only (#3193)
  Translate strings introduced in New Tab Page improvements (#3174)
  Update release workflow to use S3 bucket name from secrets (#3120)
  Handle contingency settings state on remote config (#3190)
  Add UI for displaying Duck Player contingency message #3065 (#3181)
  Open keyboard on New Tab Page based on Settings (#3187)
  Integrated macOS VPN Domain exclusion (internal release) changes into iOS. (#3164)
  Release 7.132.0-0 (#3194)
  Increase testPixelDebouncePreventsFiringWithinInterval test timeout (#3192)
  Update toolbar items for New Tab Page (#3185)
  new pixel and parameter for monitoring clearing of data stores (#3186)
  ensure new data clearing api is being used (#3191)
  If no App Store subscriptions option are available return empty options object (#3188)
  Show Intro message for existing users on New Tab Page (#3173)
  Experiment Contextual onboarding (#3160)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
This was referenced Aug 9, 2024
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afterxleep afterxleep afterxleep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bunn @afterxleep