Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privacy Pro settings updates #3189

Merged
merged 25 commits into from
Aug 14, 2024
Merged

Privacy Pro settings updates #3189

merged 25 commits into from
Aug 14, 2024

Conversation

federicocappelli
Copy link
Member

@federicocappelli federicocappelli commented Aug 5, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1205842942115003/1207746442205594/f
CC: @miasma13

Description:

New Subscription settings menu states and new subscription setting pages.

Steps to test this PR:

  1. All regular Subscription tests for all possible Subscription states (unsubscribed, subscribed, expired, no entitlements)

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone 15 Pro max
  • iPad

OS Testing:

  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 28e0a03

@federicocappelli federicocappelli marked this pull request as ready for review August 9, 2024 13:59
@federicocappelli
unused strings removed
c48a12a
@federicocappelli
Merge branch 'main' into fcappelli/privacypro_settings_updates
74ad989 
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo/SettingsViewModel.swift
#	DuckDuckGo/UserText.swift
#	DuckDuckGo/en.lproj/Localizable.strings
miasma13
miasma13 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@miasma13 miasma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@federicocappelli federicocappelli merged commit e4272fc into main Aug 14, 2024
13 checks passed
@federicocappelli federicocappelli deleted the fcappelli/privacypro_settings_updates branch August 14, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miasma13 miasma13 miasma13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@federicocappelli @miasma13