-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contextual Onboarding Pixels #3177
Merged
alessandroboron
merged 16 commits into
AleSab/implement-contextual-onboarding
from
alessandro/contextual-onboarding-pixels
Aug 5, 2024
Merged
Contextual Onboarding Pixels #3177
alessandroboron
merged 16 commits into
AleSab/implement-contextual-onboarding
from
alessandro/contextual-onboarding-pixels
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚫 The Asana task linked in the PR description is not added to iOS App Board project.
|
github-actions
bot
added
the
bot: not in app board
Added by automation for pull requests with tasks not added to iOS App Board Asana project
label
Aug 2, 2024
samsymons
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pixel testing steps worked for me, though I had an edge case issue with the flow that I sent over MM.
alessandroboron
merged commit Aug 5, 2024
e79d9ad
into
AleSab/implement-contextual-onboarding
13 of 14 checks passed
alessandroboron
added a commit
that referenced
this pull request
Aug 5, 2024
Task/Issue URL: https://app.asana.com/0/1206329551987282/1207569383033366/f **Description**: Adds Pixels for Contextual Onboarding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot: not in app board
Added by automation for pull requests with tasks not added to iOS App Board Asana project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206329551987282/1207569383033366/f
Description:
Adds Pixels for Contextual Onboarding.
Note
You may wonder why we renamed pixels with
_unique
. Since SwiftUI can redraw the view multiple times and because the user can interact with the browser, e.g. refresh the page, I’ve renamed the pixels_unique
so I can take advantage of the UniquePixel class. ODRI is across the change as per comment.Steps to test this PR:
Prerequisites:
DefaultVariantManager
at line 145.newInstallCompletion(self)
inDefaultVariantManager
at line 128.SCENARIO 1 - Linear Flow
m_dx_try_a_search_unique
is fired in console log.m_onboarding_search_option_tapped_unique
is fired in the console log.m_dx_s_unique
is fired in the console logm_dx_try_visit_site_unique
is fired in the console log.m_onboarding_visit_site_option_tapped_unique
is fired in the console log.m_dx_wt_unique
is fired in the console log.m_privacy_dashboard_first_time_used_unique
is fired in the console log. If the app is just installeddaysSinceInstall
parameter should be 0. If the privacy icon was highlightedfrom_onboarding
parameter should be true.mp
is fired.m_dx_fe_s_unique
is fired in the console log.m_dx_end_new_tab_unique
is fired in the console log.m_second_sitevisit_unique
is fired in the console log.Scenario 2 - Custom Searches
m_onboarding_search_custom_unique
is fired in the console log.www.facebook.com
and press enter.m_onboarding_visit_site_custom_unique
is fired.m_dx_sm_unique
is fired.m_second_sitevisit_unique
is fired in the console log.Scenario 3 - Site Owned by Major Trackers
whatsapp.com
in the address bar.m_dx_so_unique
is fired in the console log.Scenario 4 - Site is Major Tracker
facebook.com
in the address bar.m_dx_sm_unique
is fired in the console log.Scenario 4 - Site with no Trackers
duckduckgo.com
in the address bar.m_dx_wo_unique
is fired in the console log.Scenario 5 - Final Dialog from Contextual Dax
www.repubblica.it
m_dx_end_tab_unique
pixel fires in the console log.Definition of Done (Internal Only):
Copy Testing:
’
rather than’
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template