Unified feedback form for Privacy Pro #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
samsymons
approved these changes
Aug 9, 2024
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
|
This PR has been closed after 14 days of inactivity. Feel free to reopen it if you plan to continue working on it or have further discussions. |
quanganhdo
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Aug 27, 2024
<!-- Note: This checklist is a reminder of our shared engineering expectations. --> Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/1205922231854923/1207701941801991/f iOS PR: duckduckgo/iOS#3172 macOS PR: duckduckgo/macos-browser#3058 What kind of version bump will this require?: Major/Minor/Patch **Optional**: Tech Design URL: CC: **Description**: <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Steps to test this PR**: 1. 1. <!-- Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing. Using a simulator where a physical device is unavailable is acceptable. --> **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Aug 28, 2024
# By Anh Do (2) and others # Via Bartek Waresiak (2) and GitHub (1) * main: Add PPro unified feedback form (#3248) disable flaky test (#3283) Unified feedback form for Privacy Pro (#3172) Release 7.135.0-1 (#3280) fix back forward swipe gesture in landscape (#3278) Set onboarding completed for sync end to end tests (#3259) Release 7.135.0-0 (#3277) BSK Bump for macOS Freemium PIR RMF Attribute (No iOS Impact) (#3275) Fix math expressions on address bar (#3262) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Aug 29, 2024
# By Daniel Bernal (4) and others # Via Bartek Waresiak (2) and others * main: (32 commits) Add error pixels for Subscription keychain access errors (#3276) [DuckPlayer] 24. FrontEnd Translation (#3281) [DuckPlayer] 23. Ship Review Fixes (#3279) Logging refactoring phase #2 (#3268) Move WireGuard dependency to packet tunnel provider (#3273) Add PPro unified feedback form (#3248) disable flaky test (#3283) Unified feedback form for Privacy Pro (#3172) Release 7.135.0-1 (#3280) fix back forward swipe gesture in landscape (#3278) Set onboarding completed for sync end to end tests (#3259) Release 7.135.0-0 (#3277) BSK Bump for macOS Freemium PIR RMF Attribute (No iOS Impact) (#3275) Fix math expressions on address bar (#3262) fix progress view crash by removing call to flush (#3272) Update autoconsent to v10.15.0 (#3254) Mitigate Onboarding pixels firing with empty atb (#3265) Clean up legacy VPN navigation (#3266) Re-Enable Broken Site Toast on iOS (#3244) Bump BSK (No iOS Changes) (#3261) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205922231854923/1207701941801991/f
Tech Design URL:
CC:
Description:
Steps to test this PR:
1.
2.
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template