Improve Bookmarks DB Setup #3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
6 tasks
# By Dominik Kapusta (3) and others # Via GitHub * main: New Tab Page Settings (#3140) New Tab Page Settings Storage (#3159) Prevent endless rekey and tunnel update cycle (#3091) tentatively fix content blocking UI test (#3141) Update Autofill UI test to reflect updated app copy (#3158) Duck player support on RMF (#3146) Release 7.131.0-0 (#3157) Update BSK with autofill 12.1.0 (#3155) Report Autofill issues via Passwords screen (#3116) Update GRDB to 2.4.0 (upstream 6.29.0, SQLCipher 4.6.0) (#3153) Update fastlane to 2.222.0 (#3154) [DuckPlayer] 13. Add openInfo message to Overlay (#3151) [DuckPlayer] 12. Ensure DuckPlayer does not leak without the proper config (#3147) [DuckPlayer] 11. Tab views and Pixel updates (#3145) Remove the NETWORK_PROTECTION compilation flag (#3139) Add favorites empty state tooltip (#3119) Bump submodules/privacy-reference-tests from `a603ff9` to `afb4f61` (#3113) iOS 14 deprecation cleanup (#3098) Update Xcode version to 15.4 (#3142) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# By Alexey Martemyanov (2) and others # Via Alexey Martemyanov (2) and GitHub (1) * main: Add RMF `messageShown` attribute (#3176) Enable favorites reordering on New Tab Page (#3169) [DuckPlayer]. 15. Move DuckPlayer code to BSK (#3171) Update autoconsent to v10.13.0 (#3178) application lock test and tab switcher test (#3163) Release 7.131.0-1 (#3179) restore CrashLogMessageExtractor with disabled __cxa_throw swapper (#3133) Automatically add Asana task to iOS App Board (#3168) [DuckPlayer] 14. Potential fix to crash (#3161) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
pushed a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Aug 4, 2024
Required: Task/Issue URL: https://app.asana.com/0/856498667320406/1207875839908777/f iOS PR: duckduckgo/iOS#3143 macOS PR: duckduckgo/macos-browser#3033 What kind of version bump will this require?: Major Description: Tweak code to improve error handling and events propagation in Clients. Add protocols for improved testability.
samsymons
approved these changes
Aug 5, 2024
samsymons
added a commit
that referenced
this pull request
Aug 5, 2024
# By Alexey Martemyanov (2) and others # Via Alexey Martemyanov (2) and GitHub (1) * main: Improve Bookmarks DB Setup (#3143) Add RMF `messageShown` attribute (#3176) Enable favorites reordering on New Tab Page (#3169) [DuckPlayer]. 15. Move DuckPlayer code to BSK (#3171) Update autoconsent to v10.13.0 (#3178) application lock test and tab switcher test (#3163) Release 7.131.0-1 (#3179) restore CrashLogMessageExtractor with disabled __cxa_throw swapper (#3133) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/856498667320406/1207875839908777/f
Description:
Tweak Database setup code to better detect abnormal conditions. Remove old pixel.
Steps to test this PR:
Perform clean install tests - if stack is created as expected with no weird Pixels/errors.
Perform app update tests - if stack is opened as expected with no weird Pixels/errors.
Perform out of space tests:
hdiutil create -size 1m -fs HFS+ 1MB.dmghdiutil attach 1MB.dmg -mountpoint <db location>to mount 1MB image over the container.With this setup you should be able to see how app behaves when you restart it.
Definition of Done (Internal Only):
Device Testing:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template