restore CrashLogMessageExtractor with disabled __cxa_throw swapper #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 24, 2024
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
mallexxx
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Aug 2, 2024
mallexxx
force-pushed
the
alex/process-mach-header
branch
from
ffd9c1b to
fe78853
Compare
mallexxx
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Aug 2, 2024
samsymons
added a commit
that referenced
this pull request
Aug 4, 2024
# By Alexey Martemyanov (2) and others # Via Alexey Martemyanov (2) and GitHub (1) * main: Enable favorites reordering on New Tab Page (#3169) [DuckPlayer]. 15. Move DuckPlayer code to BSK (#3171) Update autoconsent to v10.13.0 (#3178) application lock test and tab switcher test (#3163) Release 7.131.0-1 (#3179) restore CrashLogMessageExtractor with disabled __cxa_throw swapper (#3133) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Aug 4, 2024
# By Alexey Martemyanov (2) and others # Via Alexey Martemyanov (2) and GitHub (1) * main: Add RMF `messageShown` attribute (#3176) Enable favorites reordering on New Tab Page (#3169) [DuckPlayer]. 15. Move DuckPlayer code to BSK (#3171) Update autoconsent to v10.13.0 (#3178) application lock test and tab switcher test (#3163) Release 7.131.0-1 (#3179) restore CrashLogMessageExtractor with disabled __cxa_throw swapper (#3133) Automatically add Asana task to iOS App Board (#3168) [DuckPlayer] 14. Potential fix to crash (#3161) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Aug 5, 2024
# By Alexey Martemyanov (2) and others # Via Alexey Martemyanov (2) and GitHub (1) * main: Improve Bookmarks DB Setup (#3143) Add RMF `messageShown` attribute (#3176) Enable favorites reordering on New Tab Page (#3169) [DuckPlayer]. 15. Move DuckPlayer code to BSK (#3171) Update autoconsent to v10.13.0 (#3178) application lock test and tab switcher test (#3163) Release 7.131.0-1 (#3179) restore CrashLogMessageExtractor with disabled __cxa_throw swapper (#3133) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414709148257752/1207878606354585/f
BSK PR: duckduckgo/BrowserServicesKit#909
macOS PR: duckduckgo/macos-browser#3011
Description:
swapCxaThrow: falseparameter toCrashLogMessageExtractor.setUpto allow disabling__cxa_throwswappingSteps to test this PR:
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template