Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix address bar weirdness #2810

Merged
merged 3 commits into from
May 1, 2024
Merged

fix address bar weirdness #2810

merged 3 commits into from
May 1, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented May 1, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/414235014887631/1207197707567292/f
Tech Design URL:
CC:

Description:
Use less intrusive mechanism to detect user tap on field.

Steps to test this PR:

  1. Open a new tab and tap on the address field. Should fire m.addressbar.click.ntp pixel
  2. Perform a search and tap on the address field. Should fire m.addressbar.click.serp pixel
  3. Visit a website and tap on the address field. Should fire m.addressbar.click.website pixel
  4. In settings ensure 'show keyboard on new tab' is enabled then long press the tab bar switcher button to open a new tab. The ntp pixel should NOT fire.
  5. In settings ensure 'show keyboard on app launch' is enabled then launch the app from cold. The address bar click pixel should NOT fire.
  6. Smoke test auto clear and fireproofing

brindy added 2 commits May 1, 2024 12:35
@brindy
fix address bar weirdness
8779984 
use less intrusive mechanism to detect user tap on field
@brindy
tweak for web page clicking
aee6106
@brindy brindy changed the base branch from main to release/7.118.0 May 1, 2024 11:42
@brindy brindy requested a review from quanganhdo May 1, 2024 11:44
@brindy brindy merged commit 41f554d into release/7.118.0 May 1, 2024
14 of 15 checks passed
@brindy brindy deleted the brindy/fix-addressbar-weirdness branch May 1, 2024 15:29
samsymons added a commit that referenced this pull request May 1, 2024
@samsymons
Merge branch 'main' into sam/wire-up-error-ui
13dc922 
* main:
  Release 7.118.0-1 (#2812)
  [Release PR] Update VPN metadata reporter (#2808)
  fix address bar weirdness (#2810)
  Fix RMF button styling for "big_two_action" format (#2811)
  Existing experiment disabled, the new Settings experiment activated (#2801)
  Create Asana Subtask on PR requested (#2803)
  Remove ATB from default params (#2430)
  Fix Kingfisher deprecation warnings (#2799)
  VPN server failure detection recovery (#2779)
  Disable the feedback send button when there’s no text (#2800)
samsymons added a commit that referenced this pull request May 1, 2024
@samsymons
Merge branch 'main' into sam/remove-subscription-bsk-dependency
a8b5faa 
# By Sam Symons (3) and others
# Via Chris Brind (1) and GitHub (1)
* main:
  Release 7.118.0-1 (#2812)
  [Release PR] Update VPN metadata reporter (#2808)
  fix address bar weirdness (#2810)
  Fix RMF button styling for "big_two_action" format (#2811)
  Existing experiment disabled, the new Settings experiment activated (#2801)
  Create Asana Subtask on PR requested (#2803)
  Remove ATB from default params (#2430)
  Fix Kingfisher deprecation warnings (#2799)
  VPN server failure detection recovery (#2779)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quanganhdo quanganhdo quanganhdo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brindy @quanganhdo