Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 7.116.0 with 7.115.1 hotfix #2773

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Apr 22, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1207124886620345/f
Tech Design URL:
CC:

Description:

This is a patch applying 7.115.1 hotfix to 7.116.0, using #2767 (reverts commit cebfbf5) and #2769.

Steps to test this PR:

  1. Set auto-clear on, and on exit app
  2. Go to Reddit, login, and do some queries on Google
  3. kill the app, and come back
  4. you shouldn’t be logged it on Reedit, and you shouldn’t see any old queries in Google

Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 marked this pull request as ready for review April 22, 2024 09:43
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dus7 as discussed in MM, this did fix the cookie clearing issue however it appears to have introduced a couple of other issues where long pressing on a link to open a new tab (or in background) no longer works and Settings cannot be opening from the browsing menu

@dus7
Copy link
Contributor Author

dus7 commented Apr 22, 2024

@dus7 as discussed in MM, this did fix the cookie clearing issue however it appears to have introduced a couple of other issues where long pressing on a link to open a new tab (or in background) no longer works and Settings cannot be opening from the browsing menu

The hotfix comprised of two PR's. The second one (#2769) was not present in my local checkout of hotfix/7.115.1 and there's no tag for 7.115.1-1 so I did a cherry-pick of the remaining one.

Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dus7 dus7 merged commit 1c8d034 into release/7.116.0 Apr 22, 2024
18 checks passed
@dus7 dus7 deleted the mariusz/patch-7.116.0 branch April 22, 2024 11:10
samsymons added a commit that referenced this pull request Apr 23, 2024
* main:
  lastDisconnectError now matches against NEVPNConnectionError (#2753)
  Release 7.116.0-3 (#2774)
  Patch 7.116.0 with 7.115.1 hotfix (#2773)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants