Fix crash when quickly adding/removing tabs in switcher #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dus7
changed the title
dus7
commented
Apr 17, 2024
| @@ -123,12 +123,12 @@ class TabViewCell: UICollectionViewCell { | |||
| } | |||
|
|
|||
| private func startRemoveAnimation() { | |||
| self.isDeleting = true | |||
| self.deleteTab() | |||
There was a problem hiding this comment.
This allows for shorter delay before adding a tab is again possible. Based on my checks it does not interfere with animations. Once this function is called, the gesture is committed anyway.
samsymons
added a commit
that referenced
this pull request
Apr 18, 2024
* main: Release 7.116.0-1 (#2761) Remove validator app (#2754) Fix crash when quickly adding/removing tabs in switcher (#2760) Fix settings navigation bar colors after reopening (#2758) Alpha ad-hoc lane (#2492) Keep a weak reference to UserScriptMessageBroker (#2755) Add refresh config cell to top of debug (#2735) VPN: Replace available interfaces in VPN metadata (#2750) Require device auth to be set in order to use Sync (#2722) Add new iOS pixels for measuring navigation (#2730) Privacy pro metadata updates (#2747) Update autoconsent to v10.6.1 (#2734) Limit Stale actions to issues (#2745) Change DAU pixel for VPN to weekly (#2684) Support Autofill Domains with Port Number Suffixes (#2715) Update secure vault error pixels to fire daily (#2557) Subscription: Fix 'Back' button not present (#2741) Subscription State improvements + Remove SUBSCRIPTION Flag (#2726) Release 7.116.0-0 (#2739) Release 7.116.0-0 (#2737)
samsymons
added a commit
that referenced
this pull request
Apr 20, 2024
# By Daniel Bernal (11) and others # Via Mariusz Śpiewak (3) and others * main: (63 commits) Release 7.115.1-1 (#2770) Fix iOS auto-clearing fails to remove cookies (#2769) Release 7.115.1-0 (#2768) Fix iOS auto-clearing fails to remove cookies (#2767) iOS: VPN screen improvements (#2721) Release 7.116.0-2 (#2763) Remove "Thank You" prompt (#2762) Test to ensure that page refresh doesn't affect url bar focus (#2749) Add support for uploading crash reports to Sentry (#2720) Replace SwiftLintPlugin with SwiftLintTool (#2710) Release 7.116.0-1 (#2761) Remove validator app (#2754) Fix crash when quickly adding/removing tabs in switcher (#2760) Fix settings navigation bar colors after reopening (#2758) Alpha ad-hoc lane (#2492) Keep a weak reference to UserScriptMessageBroker (#2755) Add refresh config cell to top of debug (#2735) VPN: Replace available interfaces in VPN metadata (#2750) Require device auth to be set in order to use Sync (#2722) Add new iOS pixels for measuring navigation (#2730) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/AppDelegate.swift # DuckDuckGo/MainViewController.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1204624719960838/f
Tech Design URL:
CC:
Description:
This PR prevents internal inconsistency during CollectionView updates by not allowing to add a tab to model during batch updates execution block.
Steps to test this PR:
—
Internal references:
Software Engineering Expectations
Technical Design Template