Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Thank You messaging is shown, stop the tunnel #2656

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

quanganhdo
Copy link
Member

@quanganhdo quanganhdo commented Mar 27, 2024

Task/Issue URL: https://app.asana.com/0/0/1206944215322925/f
Tech Design URL:
CC:

Description:

Steps to test this PR:

  1. Under Debug > NetP > Choose Reset Thank you messaging
  2. Remove all builds from your device after making sure you are waitlisted
  3. Install the new build
  4. Connect to the VPN and authenticate as internal user
  5. Expect: Thank you messaging and tunnel should be stopped

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Mar 27, 2024
@quanganhdo quanganhdo marked this pull request as ready for review March 27, 2024 21:15
@quanganhdo quanganhdo requested a review from samsymons March 27, 2024 21:15
@quanganhdo quanganhdo removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Mar 27, 2024
@quanganhdo quanganhdo changed the base branch from main to release/7.113.0 March 27, 2024 21:22
@quanganhdo quanganhdo merged commit 0bb1510 into release/7.113.0 Mar 27, 2024
23 checks passed
@quanganhdo quanganhdo deleted the anh/pp/stop-tunnel-and-show-thank-you branch March 27, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants