Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab loading #2410

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix tab loading #2410

merged 1 commit into from
Jan 30, 2024

Conversation

bwaresiak
Copy link
Collaborator

@bwaresiak bwaresiak commented Jan 30, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1206457470836092/f
Tech Design URL:
CC:

Description:

Fix tab loading on first navigation by ensuring assets are processed from the moment app is created.

Steps to test this PR:

Check content blocking and privacy tests.

  1. Load website in the tab, then open another tab with Home screen. Stay on home screen and kill the app.
  2. Restart the app, wait 10s so rules are processed.
  3. Switch to tab with website - it should load.
  4. Create new tab and navigate somewhere - it should load.

Device Testing:

  • iPhone
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Internal references:

Software Engineering Expectations
Technical Design Template

@bwaresiak bwaresiak requested review from brindy and jaceklyp January 30, 2024 07:41
Copy link
Contributor

@jaceklyp jaceklyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwaresiak bwaresiak merged commit 6c58c3c into release/7.106.0 Jan 30, 2024
14 checks passed
@bwaresiak bwaresiak deleted the bartek/fix-tab-loading branch January 30, 2024 09:06
samsymons added a commit that referenced this pull request Feb 4, 2024
* main: (41 commits)
  Update BSK with autofill 10.1.0 (#2414)
  Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2408)
  Add Autoconsent onByDefault subfeature (#2423)
  Metadata reverted https://app.asana.com/0/0/1206476969305202/1206481077004998/f
  metadata updated
  Release 7.107.0-0 (#2421)
  More script fixes (#2419)
  More release script fixes (#2418)
  Release/7.106.0-4 (#2417)
  Reenable toggle on disallowing vpn (#2404) (#2416)
  Don't crash when AppRatingPromptEntity fetch errors (#2388)
  Add error codes to site breakage reports (#2413)
  Don't set dryRun for alpha builds (#2412)
  Add VPN redemption retry event (#2409)
  Changes to hotfix process (#2406)
  Release/7.106.0-3 changes (#2411)
  Fix tab loading (#2410)
  Improve waitlist invite code checks (#2398)
  Reenable toggle on disallowing vpn (#2404)
  Bump BrowserServicesKit to 103.0.2 (#2393)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants