Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix voice search settings #2401

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix voice search settings #2401

merged 1 commit into from
Jan 29, 2024

Conversation

Bunn
Copy link
Contributor

@Bunn Bunn commented Jan 29, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1206454436350674/f

Cherry picked from: #2394

Description:
Fix voice-search toggle in Settings
See parent task for steps to reproduce the issue

Steps to test this PR:

  1. Delete app to start clean
  2. Open the app, check if voice-search is default to off and there's no mic in the address bar
  3. Change the settings to ON, accept the permission alert.
  4. Close the settings screen, check if the mic icon is visible in the address bar. Tap the mic to see if the feature is working (better to test on a real device)
  5. Force close the app, check if the settings is still ON.
  6. Turn it off, force close app, and check if settings is still OFF

@Bunn Bunn mentioned this pull request Jan 29, 2024
@Bunn Bunn requested a review from brindy January 29, 2024 10:18
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brindy brindy merged commit 75e98e4 into release/7.106.0 Jan 29, 2024
10 checks passed
@brindy brindy deleted the bunn/voice-fix-cherry branch January 29, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants