Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert using content insets to fix page position problem #2356

Merged
merged 2 commits into from
Jan 18, 2024
Merged

revert using content insets to fix page position problem #2356

merged 2 commits into from
Jan 18, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jan 18, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1205688349294686/f
Tech Design URL:
CC:

Description:

Fixes a problem with the bottom offset.

Steps to test this PR:

  1. Visit reddit.com - ensure "continue with prompt" is aligned with bottom of the screen and easily accessible to the user
  2. Visit TikTok.com - ensure prompts are aligned with bottom of the screen and easily accessible to the user
  3. Browse the web and ensure the page position is not forgotten when browsing to the previous page.
  4. Validate on iPhone and iPad

@brindy brindy requested a review from graeme January 18, 2024 11:12
@brindy brindy changed the title tweak page position revert using content insets to fix page position problem Jan 18, 2024
@brindy
Copy link
Contributor Author

brindy commented Jan 18, 2024

Examples of reddit and tiktok prompts:

Screenshot 2024-01-18 at 11 43 08 Screenshot 2024-01-18 at 11 43 00

@graeme graeme merged commit 3678c64 into release/7.105.0 Jan 18, 2024
10 checks passed
@graeme graeme deleted the brindy/page-position-fix-tweak branch January 18, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graeme graeme graeme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brindy @graeme