Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve UI scaling problems #2327

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

SabrinaTardio
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1204186595873227/1206325612834204/f

Description: Fix some scaling issues see task

Steps to test this PR:

  1. Try the sync UI flow with different size phones
  2. Try with small device and double length pseudo language setting

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@SabrinaTardio SabrinaTardio requested a review from ayoy January 11, 2024 12:28
@ayoy ayoy force-pushed the sabrina/sync-ui-glitches branch from 5cee86a to a4696ea Compare January 11, 2024 13:51
@ayoy ayoy changed the base branch from main to release/7.104.0 January 11, 2024 13:51
@ayoy ayoy force-pushed the sabrina/sync-ui-glitches branch from a4696ea to d71b430 Compare January 11, 2024 14:08
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@SabrinaTardio SabrinaTardio merged commit eaafe0b into release/7.104.0 Jan 11, 2024
10 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/sync-ui-glitches branch January 11, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants