Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant orientation detection #2178

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Nov 20, 2023

Task/Issue URL: https://app.asana.com/0/414709148257752/1205887735214021/f
Tech Design URL:
CC:

Description:

Fix text selection bug.

Steps to test this PR:
Test on real iPhone:

  1. Open a web page (not SERP)
  2. Tap text to select it
  3. Re-orient the device
  4. Selection should remain

Internal references:

Software Engineering Expectations
Technical Design Template

@brindy brindy requested a review from miasma13 November 20, 2023 22:01
Copy link
Contributor

@miasma13 miasma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brindy brindy merged commit 2329ac8 into develop Nov 21, 2023
11 checks passed
@brindy brindy deleted the brindy/fix-text-selection-bug branch November 21, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants