Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unarchiveTopLevelObjectWithData deprecation #2176

Merged

Conversation

federicocappelli
Copy link
Member

@federicocappelli federicocappelli commented Nov 20, 2023

Task/Issue URL: https://app.asana.com/0/414709148257752/1205990984763603/f

Description:

I replaced the deprecated (iOS 12) API unarchiveTopLevelObjectWithData maintaining the use of non-secure coding in order to achieve backward compatibility with the already saved Tabs.

All functions that can throw errors are now correctly handled and in case of error a log is added.

Steps to test this PR:

  1. Install the current app and save tabs
  2. Update the new app version and check if the tabs are still there.

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to work. Just one minor comment, then feel free to merge.

DuckDuckGo/TabsModelPersistenceExtension.swift Outdated Show resolved Hide resolved
@federicocappelli federicocappelli merged commit a70e29e into develop Nov 21, 2023
5 of 6 checks passed
@federicocappelli federicocappelli deleted the fcappelli/unarchiveTopLevelObjectWithData_deprecation branch November 21, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants