Breakage report improvements #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… impl commented out
…ub.com/duckduckgo/iOS into fcappelli/breakage_report_improvements # Conflicts: # DuckDuckGo/PrivacyDashboard/PrivacyDashboardViewController.swift # DuckDuckGo/ReportBrokenSiteView.swift # DuckDuckGo/ReportBrokenSiteViewController.swift
…port broken site popup window size is now adapted to the content
…pelli/breakage_report_improvements # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/BrokenSiteInfo.swift
6 tasks
federicocappelli
added
the
dependencies
15 tasks
federicocappelli
changed the title
federicocappelli
changed the title
federicocappelli
requested review from
bwaresiak and
tomasstrba
and removed request for
bwaresiak
…pelli/breakage_report_improvements # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
There was a problem hiding this comment.
ReportBrokenWebsite part removed from this storyboard
There was a problem hiding this comment.
ReportBrokenWebsite segue removed and replaced with the PrivacyDashboardVC
There was a problem hiding this comment.
Note: All these new strings are coming from the VPN implementation, from some reasons they were not present. I paired with Bartek and this change is ok, it's just removing the right strings and adding the new ones
tomasstrba
approved these changes
Nov 22, 2023
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
federicocappelli
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 27, 2023
Task/Issue URL: https://app.asana.com/0/1205842942115003/1205692741026215/f iOS PR: duckduckgo/iOS#2168 macOS PR: duckduckgo/macos-browser#1864 What kind of version bump will this require?: Major (Braking changes in privacy-dashboard) **Description**: The previous implementation of the `Report Broken Site` page was different between iOS and macOS, with this PR I have updated and aligned the PrivacyDashboardController so the web implementation of the `Report Broken Site` can be used in both iOS and macOS. The changes are mostly around delegates and which User script is handled for each platform. - Splitting the delegate into 3 new delegates: `PrivacyDashboardNavigationDelegate`, `PrivacyDashboardReportBrokenSiteDelegate`, `PrivacyDashboardControllerDelegate`
6 tasks
federicocappelli
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Dec 6, 2023
Task/Issue URL: https://app.asana.com/0/1205842942115003/1205692741026215/f iOS PR: duckduckgo/iOS#2168 macOS PR: duckduckgo/macos-browser#1864 What kind of version bump will this require?: Major (Braking changes in privacy-dashboard) Description: The previous implementation of the Report Broken Site page was different between iOS and macOS, with this PR I have updated and aligned the PrivacyDashboardController so the web implementation of the Report Broken Site can be used in both iOS and macOS. The changes are mostly around delegates and which User script is handled for each platform. Splitting the delegate into 3 new delegates: PrivacyDashboardNavigationDelegate, PrivacyDashboardReportBrokenSiteDelegate, PrivacyDashboardControllerDelegate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205842942115003/1205692741026215/f
Tech Design URL: https://app.asana.com/0/1205842942115003/1205917507991804/f
Description:
This PR introduces a new version of BSK (PR: duckduckgo/BrowserServicesKit#566) that allows iOS and macOS to share the same web implementation of the
ReportBrokenSitepage and introduce improvements to Pixels and the broken site report data.Additional changes
Report broken sitepage has been removedSteps to test this PR:
Access
Report broken sitevia privacy dashboardPrivacy DashboardReport broken sitevia thewebsite not workinglink on top of the pageAccess
Report broken sitevia menuCopy Testing:
No new copy to test
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing: