Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations for Autofill "Never Save for this Site" feature #2157

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Translations for Autofill "Never Save for this Site" feature #2157

merged 1 commit into from
Nov 16, 2023

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Nov 14, 2023 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/0/1205159380096691/f
Tech Design URL:
CC:

Description:
Translations for "Never save for this Site" autofill functionality

Steps to test this PR:

  1. Switching your iPhone to another language e.g. French, visit https://fill.dev/form/login-simple and login using credentials you do not have saved
  2. In the Save Login prompt confirm the bottom CTA button is localised
image
  1. Go to the Logins screen and confirm the Reset Excluded Sites row is localised
  2. Tap the row and confirm the action sheet presented is localised
image

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '
Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 requested review from a team, jaceklyp and tomasstrba and removed request for a team and jaceklyp November 14, 2023 16:14
tomasstrba
tomasstrba approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 I didn't risk switching to French and getting lost and rather used Slovak 😄

Screenshot 2023-11-16 at 2 12 27 PM Screenshot 2023-11-16 at 2 13 09 PM Screenshot 2023-11-16 at 2 13 33 PM

@amddg44 amddg44 merged commit 41b7dff into anya/autofill-never-prompt-save Nov 16, 2023
14 checks passed
@amddg44 amddg44 deleted the anya/autofill-never-prompt-translation branch November 16, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasstrba tomasstrba tomasstrba approved these changes

Assignees

@amddg44 amddg44

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amddg44 @tomasstrba