Update about screen #2152
Merged
Update about screen #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brindy
requested review from
a team,
jaceklyp and
amddg44
and removed request for
a team and
jaceklyp
amddg44
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
LGTM! Tested on the following in portrait, landscape, light / dark mode (and also larger font sizes and that the links work) 😅 :
-
iOS 17
-
iPhone 15 Pro Max
-
iPhone 15 Pro
-
iPhone 15
-
iPhone 13 Mini
-
iPhone SE (Gen 2)
-
iPad Pro
-
iPad Air
-
iPad Mini
-
iOS 16
-
iPhone 13 Pro Max
-
iPhone 13 Pro
-
iPhone 13
-
iPhone 13 Mini
-
iPhone SE (Gen 2)
-
iPad Pro
-
iPad Air
-
iPad Mini
-
iOS 15:
-
iPhone 13 Pro Max
-
iPhone 13 Pro
-
iPhone 13
-
iPhone 12 Mini
-
iPhone SE (Gen 1)
-
iPad Pro
-
iPad Air
-
iPad Mini
|
Epic @amddg44 ! Thank you :) |
samsymons
added a commit
that referenced
this pull request
Nov 16, 2023
* develop: (36 commits) Rolls back a BSK change by mistake Updates BSK Updates BSK Document LinkPresentation usage (#2172) Autofill "Never Save for this Site" feature (#2104) Use upstream fastlane 2.217.0 (#2161) Update about screen (#2152) Fixes a crasher due to a test line merged by mistake. (#2162) remove return user pixel (#2146) Revert to auto signing (#2158) BSK changes for NetP iOS Geoswitching (#2141) Update sync e2e tests to new setup flow (#2151) Fix for duplicated "atb" in Pixel request (#2139) Updating tests to support latest reference tests (#2145) Add NetP widget (#2142) Normalize ampUrl in breakage pixel (#2154) Update embedded files Update version number Bump submodules/privacy-reference-tests from `0d23f76` to `7519c3d` (#2135) Properly refresh home page favorites view when updating favorites display mode (#2148) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414709148257752/1205916913109009/f
Tech Design URL:
CC:
Description:
Convert about screen to SwiftUI and update content.
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template