Update BSK for NetP change #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
diegoreymendez
approved these changes
Nov 8, 2023
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 8, 2023
#553) Task/Issue URL: https://app.asana.com/0/0/1205909514194474/f iOS PR: duckduckgo/iOS#2134 macOS PR: duckduckgo/macos-browser#1820 What kind of version bump will this require?: Patch Optional: Tech Design URL: CC: Description: This PR updates the NetP pixel to be more reliable. It was previously only sent when rekey was called, but rekeying can happen without going through this function at all, so now we check whether we can send the pixel any time the connection tester has completed a test.
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 8, 2023
#553) Task/Issue URL: https://app.asana.com/0/0/1205909514194474/f iOS PR: duckduckgo/iOS#2134 macOS PR: duckduckgo/macos-browser#1820 What kind of version bump will this require?: Patch Optional: Tech Design URL: CC: Description: This PR updates the NetP pixel to be more reliable. It was previously only sent when rekey was called, but rekeying can happen without going through this function at all, so now we check whether we can send the pixel any time the connection tester has completed a test.
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 9, 2023
#553) Task/Issue URL: https://app.asana.com/0/0/1205909514194474/f iOS PR: duckduckgo/iOS#2134 macOS PR: duckduckgo/macos-browser#1820 What kind of version bump will this require?: Patch Optional: Tech Design URL: CC: Description: This PR updates the NetP pixel to be more reliable. It was previously only sent when rekey was called, but rekeying can happen without going through this function at all, so now we check whether we can send the pixel any time the connection tester has completed a test.
samsymons
added a commit
that referenced
this pull request
Nov 9, 2023
# By Christopher Brind (3) and others # Via GitHub (1) and Michal Smaga (1) * develop: Support environment setting (#2140) Update BSK (#2136) Update BSK for NetP change (#2134) Update test to match exact tracker (#2133) Avoid AppTP DB initialization when disabled (#2090) re-enable keyboard shortcuts (#2132) fix favorite launch with keyboard bug (#2131) Fix syncing empty favorites folders (#2121) kill variant when receiving atb update (#2130) Adding 'protectionsState' to breakage form submission (#2120) Release 7.96.0 (#2128) Update remote messaging production url (#2124) Alert user about abnormal app conditions (#2110) # Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Nov 10, 2023
* develop: Support environment setting (#2140) Update BSK (#2136) Update BSK for NetP change (#2134) Update test to match exact tracker (#2133) Avoid AppTP DB initialization when disabled (#2090) re-enable keyboard shortcuts (#2132) fix favorite launch with keyboard bug (#2131) Fix syncing empty favorites folders (#2121) kill variant when receiving atb update (#2130) Adding 'protectionsState' to breakage form submission (#2120) Release 7.96.0 (#2128) Update remote messaging production url (#2124) Alert user about abnormal app conditions (#2110) Add e2e test for email protection deep-links (#2123) Update to config v4 (#2114)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205909514194474/f
Tech Design URL:
CC:
Description:
This PR updates BSK to account for a NetP change.
Steps to test this PR:
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template