Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply container background to widgets #2126

Closed
wants to merge 3 commits into from
Closed

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Nov 3, 2023

Task/Issue URL: https://app.asana.com/0/414709148257752/1205862739369423/f
Tech Design URL:
CC:

Description:

When building with Xcode 15 the widgets require a container background.

Steps to test this PR:

  1. Build and run the app using Xcode 15
  2. Add all the widgets to the Home Screen and confirm they render correctly
  3. Add Lock Screen widgets and confirm they render correctly

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@jaceklyp jaceklyp deleted the branch develop December 6, 2023 15:48
@jaceklyp jaceklyp closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants