Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remote messaging production url #2124

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Nov 2, 2023

Task/Issue URL: https://app.asana.com/0/414709148257752/1205648554243412/f
Tech Design URL:
CC:

Description:
Update the RMF production URL to be the correct production URL

Steps to test this PR:

  1. In RemoteMessageRequest.swift comment out the debug URL so you are testing against the production URL
  2. In the same file set a breakpoint at line 53
  3. Run up the app and confirm that the RMF response object data matches that of the production json i.e. version = 12 and both messages & rules are empty

image

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 requested a review from brindy November 2, 2023 13:18
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amddg44 amddg44 merged commit 5cc3464 into develop Nov 6, 2023
9 checks passed
@amddg44 amddg44 deleted the anya/update-remote-messaging-prod-url branch November 6, 2023 10:29
samsymons added a commit that referenced this pull request Nov 8, 2023
* develop:
  re-enable keyboard shortcuts (#2132)
  fix favorite launch with keyboard bug (#2131)
  Fix syncing empty favorites folders (#2121)
  kill variant when receiving atb update (#2130)
  Adding 'protectionsState' to breakage form submission (#2120)
  Release 7.96.0 (#2128)
  Update remote messaging production url (#2124)
  Alert user about abnormal app conditions (#2110)
  Add e2e test for email protection deep-links (#2123)
  Update to config v4 (#2114)
  Release 7.95.0 (#2122)
  Add toggling of NetP Notifications to iOS (#2112)
  Fix for deeplink crash when preparing webview preview (#2116)
  Integrates the latest DBP changes in BSK (#2108)
  Switch to next phase of new experiment for UA (#2118)
samsymons added a commit that referenced this pull request Nov 9, 2023
# By Christopher Brind (3) and others
# Via GitHub (1) and Michal Smaga (1)
* develop:
  Support environment setting (#2140)
  Update BSK (#2136)
  Update BSK for NetP change (#2134)
  Update test to match exact tracker (#2133)
  Avoid AppTP DB initialization when disabled (#2090)
  re-enable keyboard shortcuts (#2132)
  fix favorite launch with keyboard bug (#2131)
  Fix syncing empty favorites folders (#2121)
  kill variant when receiving atb update (#2130)
  Adding 'protectionsState' to breakage form submission (#2120)
  Release 7.96.0 (#2128)
  Update remote messaging production url (#2124)
  Alert user about abnormal app conditions (#2110)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Nov 10, 2023
* develop:
  Support environment setting (#2140)
  Update BSK (#2136)
  Update BSK for NetP change (#2134)
  Update test to match exact tracker (#2133)
  Avoid AppTP DB initialization when disabled (#2090)
  re-enable keyboard shortcuts (#2132)
  fix favorite launch with keyboard bug (#2131)
  Fix syncing empty favorites folders (#2121)
  kill variant when receiving atb update (#2130)
  Adding 'protectionsState' to breakage form submission (#2120)
  Release 7.96.0 (#2128)
  Update remote messaging production url (#2124)
  Alert user about abnormal app conditions (#2110)
  Add e2e test for email protection deep-links (#2123)
  Update to config v4 (#2114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants