Adding 'protectionsState' to breakage form submission #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
shakyShane
changed the title
shakyShane
force-pushed
the
10-31-shane/protection-state
branch
from
647ed0b to
dcf7f34
Compare
miasma13
approved these changes
Nov 6, 2023
Comment on lines
+27
to
+30
| enum ProtectionsState: String { | ||
| case enabled = "1" | ||
| case disabled = "0" | ||
| } |
There was a problem hiding this comment.
- Not sure what is the expected way of extending the values range here, but maybe a simple bool would suffice?
- Either with the above change or not I suggest replacing "1"/"0" to "true"/"false" to be consistent with other parameters.
There was a problem hiding this comment.
Duplicating the response for visibility :)
@miasma13 as we discussed in MM - this mapping to "1" | "0" was done intentionally to match what 'other' platforms are doing with this parameter - since I'm adding to all 5 :)
samsymons
added a commit
that referenced
this pull request
Nov 8, 2023
* develop: re-enable keyboard shortcuts (#2132) fix favorite launch with keyboard bug (#2131) Fix syncing empty favorites folders (#2121) kill variant when receiving atb update (#2130) Adding 'protectionsState' to breakage form submission (#2120) Release 7.96.0 (#2128) Update remote messaging production url (#2124) Alert user about abnormal app conditions (#2110) Add e2e test for email protection deep-links (#2123) Update to config v4 (#2114) Release 7.95.0 (#2122) Add toggling of NetP Notifications to iOS (#2112) Fix for deeplink crash when preparing webview preview (#2116) Integrates the latest DBP changes in BSK (#2108) Switch to next phase of new experiment for UA (#2118)
samsymons
added a commit
that referenced
this pull request
Nov 9, 2023
# By Christopher Brind (3) and others # Via GitHub (1) and Michal Smaga (1) * develop: Support environment setting (#2140) Update BSK (#2136) Update BSK for NetP change (#2134) Update test to match exact tracker (#2133) Avoid AppTP DB initialization when disabled (#2090) re-enable keyboard shortcuts (#2132) fix favorite launch with keyboard bug (#2131) Fix syncing empty favorites folders (#2121) kill variant when receiving atb update (#2130) Adding 'protectionsState' to breakage form submission (#2120) Release 7.96.0 (#2128) Update remote messaging production url (#2124) Alert user about abnormal app conditions (#2110) # Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Nov 10, 2023
* develop: Support environment setting (#2140) Update BSK (#2136) Update BSK for NetP change (#2134) Update test to match exact tracker (#2133) Avoid AppTP DB initialization when disabled (#2090) re-enable keyboard shortcuts (#2132) fix favorite launch with keyboard bug (#2131) Fix syncing empty favorites folders (#2121) kill variant when receiving atb update (#2130) Adding 'protectionsState' to breakage form submission (#2120) Release 7.96.0 (#2128) Update remote messaging production url (#2124) Alert user about abnormal app conditions (#2110) Add e2e test for email protection deep-links (#2123) Update to config v4 (#2114)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205839123798771/f
Tech Design URL:
CC:
Description:
Adds a new parameter to breakage form submissions
Steps to test this PR:
protectionsStatehas either a "0" or "1" value based on the rules mentioned in the Asana task.Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template