Autofill "Never Save for this Site" feature #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttingsListViewController
…current webview never prompt status
…r-prompt-save # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
…r-prompt-save # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
… is disabled in settings
…r-prompt-save # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
6 tasks
…r-prompt-save # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
afterxleep
approved these changes
Nov 13, 2023
Task/Issue URL: https://app.asana.com/0/0/1205159380096691/f Tech Design URL: CC: Description: Translations for "Never save for this Site" autofill functionality
Task/Issue URL: https://app.asana.com/0/72649045549333/1205786958985456/f Tech Design URL: CC: Description: Removes the website favicon + url at the top of the autofill prompts and add app icon to the top of all autofill prompts. Also updates copy to replace the word logins with passwords
…r-prompt-save # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
amddg44
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 16, 2023
Task/Issue URL: https://app.asana.com/0/0/1205783642285427/f iOS PR: duckduckgo/iOS#2104 macOS PR: duckduckgo/macos-browser#1827 What kind of version bump will this require?: Minor Description: Adds Autofill "Never Save for this Site" support for iOS
samsymons
added a commit
that referenced
this pull request
Nov 16, 2023
* develop: (36 commits) Rolls back a BSK change by mistake Updates BSK Updates BSK Document LinkPresentation usage (#2172) Autofill "Never Save for this Site" feature (#2104) Use upstream fastlane 2.217.0 (#2161) Update about screen (#2152) Fixes a crasher due to a test line merged by mistake. (#2162) remove return user pixel (#2146) Revert to auto signing (#2158) BSK changes for NetP iOS Geoswitching (#2141) Update sync e2e tests to new setup flow (#2151) Fix for duplicated "atb" in Pixel request (#2139) Updating tests to support latest reference tests (#2145) Add NetP widget (#2142) Normalize ampUrl in breakage pixel (#2154) Update embedded files Update version number Bump submodules/privacy-reference-tests from `0d23f76` to `7519c3d` (#2135) Properly refresh home page favorites view when updating favorites display mode (#2148) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205783642285427/f
Tech Design URL: https://app.asana.com/0/481882893211075/1205590957854802/f
CC:
Description:
Adds the functionality to allow users to choose to "Never Save for this Site" from the autofill save login prompt, with the option to reset this list from the Logins screen.
Steps to test this PR:
Note - I'm still waiting on translations so that will probably be a separate PR
Save Loginprompt, confirm the bottom button is nowNever Ask for This SiteTap it and confirm this pixel is fired:
m_autofill_logins_save_login_exclude_site_confirmedGo back to https://fill.dev/form/login-simple
Login again with new credentials and confirm that you no longer get the
Save LoginpromptVisit another site and, logging with new credentials, confirm the
Save Loginprompt is still presented for other sitesGo to https://fill.dev/form/registration-email and confirm that
Password Generationis disabled for this site (no key in the password field and tapping in the field does not trigger the generated password prompt) -- this is why we needed to adopt support forgetRuntimeConfigurationnowVisit another website with a registration form and confirm that
Password Generationis still enabled for itGo the Logins screen and you should see a new row with the option to
Reset Excluded SitesTap the row and confirm this pixel is fired:
m_autofill_settings_reset_excluded_displayedTap
Cancelin the action sheet that was presented and confirm this pixel is firedm_autofill_settings_reset_excluded_dismissedTap the row and choose
Reset Excluded Sitesand confirm this pixel is fired:m_autofill_settings_reset_excluded_confirmedThe
Reset Excluded Sitesrow should now be gone (it is only added to the screen when a user has at least 1 site saved asNever Prompt)Go back to https://fill.dev/form/login-simple and confirm the Save Login prompt now appears again
Final test case (a small bug fix): confirm Private Duck Addresses are not autosaved when Autofill is disabled 🙂
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template