Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new experiment for fixed UA logic #2075

Closed
wants to merge 2 commits into from
Closed

Conversation

jaceklyp
Copy link
Contributor

@jaceklyp jaceklyp commented Oct 6, 2023

Task/Issue URL: https://app.asana.com/0/1203790657351911/1205652551515177/f

CC: @jonathanKingston

Description:

Steps to test this PR:

  1. Make sure UA tests pass
  2. Install the new app and make sure you've been assigned with "mf" variant.
  3. Open any page and see if the fixed user agent is being used - the one with static WebView and Safari versions.

Internal references:

Software Engineering Expectations
Technical Design Template

@jonathanKingston
Copy link
Collaborator

Logic looks correct thank you, get someone who knows the feature flagging and variants to validate that's correct though.

@brindy brindy self-requested a review October 6, 2023 20:12
@brindy brindy self-assigned this Oct 6, 2023
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brindy brindy assigned jaceklyp and unassigned brindy Oct 9, 2023
@jaceklyp jaceklyp closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants