Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetP connection notifications improvements #2073

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

graeme
Copy link
Contributor

@graeme graeme commented Oct 6, 2023

Task/Issue URL: https://app.asana.com/0/0/1205656863843386/f

Description:

On testing the Network Protection notifications on iOS, we decided to make a few UX tweaks:
Show the same connection notifications when the user connects manually as well as when they reconnect after an interruption
Include the server location in the body text of these notifications
On iOS, replace old notifications about the connection with the latest one to remove confusion about current connection status.

Steps to test this PR:

  1. Build this branch
  2. If NetP is already started, stop it (Settings -> Network Protection)
  3. Start NetP
  4. Observe the connection notification including the server location
  5. Go to Settings -> Debug -> Network Protection
  6. Trigger a Connection Interruption
  7. Observe the interruption notification which is then replaced by the connection one

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@graeme graeme self-assigned this Oct 6, 2023
@graeme graeme marked this pull request as ready for review October 6, 2023 17:13
@graeme graeme requested a review from samsymons October 6, 2023 17:14
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this works great!

@graeme graeme merged commit 873fb58 into develop Oct 6, 2023
9 checks passed
@graeme graeme deleted the graeme/server-in-connected-notification branch October 6, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants