Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotated NetP error image #2069

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414235014887631/1205630144099782/f
Tech Design URL:
CC:

Description:

This PR removes the rotation effect that is applied when there is an error in the NetP UI.

Steps to test this PR:

  1. Enable NetP and make sure that the NetP logo looks correct before and after connection
  2. Simulate an error and check that the NetP logo looks correct (you could hardcode an error in NetworkProtectionStatusViewModel to check this)

IMG_0E27FA20978F-1

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested a review from graeme October 4, 2023 19:02
Copy link
Contributor

@graeme graeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

@graeme graeme merged commit dd7397a into develop Oct 5, 2023
9 checks passed
@graeme graeme deleted the sam/fix-rotated-netp-error-ui branch October 5, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants