Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes iOS phased rollout dry run pixel #2064

Merged
merged 5 commits into from
Oct 8, 2023
Merged

Removes iOS phased rollout dry run pixel #2064

merged 5 commits into from
Oct 8, 2023

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Oct 3, 2023 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/0/1205515530563288/f
Tech Design URL:
CC:

Description:
Removes the incremental feature flag tester and associated pixel & user default key

Steps to test this PR:

  1. Run the app and make sure no pixel related to the incremental test fires (which shouldn't be possible given that all of that code is now deleted)

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 mentioned this pull request Oct 3, 2023
Merged
6 tasks
samsymons
samsymons approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

amddg44 added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Oct 8, 2023
@amddg44
Removes incrementalRolloutTest2 (#521)
850d7b3 
Task/Issue URL: https://app.asana.com/0/0/1205515530563288/f
iOS PR: duckduckgo/iOS#2064
macOS PR: duckduckgo/macos-browser#1706
What kind of version bump will this require?: Minor

Description:
Removes test iOS phased rollout feature flag
amddg44 added 2 commits October 8, 2023 13:32
@amddg44
Merge remote-tracking branch 'origin/develop' into anya/remove-dry-ru…
fa13af5 
…n-flag-pixel

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@amddg44
Set BSK version to 81.1.0
adc20ee
@amddg44 amddg44 merged commit 495985d into develop Oct 8, 2023
9 checks passed
@amddg44 amddg44 deleted the anya/remove-dry-run-flag-pixel branch October 8, 2023 12:03
samsymons added a commit that referenced this pull request Oct 9, 2023
@samsymons
Merge branch 'develop' into sam/simplify-favicon-fetching
e0ee2fa 
* develop:
  Add parameter to multiple Autofill pixels (#2032)
  Removes iOS phased rollout dry run pixel (#2064)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsymons samsymons samsymons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amddg44 @samsymons