Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iOS 15 crash on remote messaging #2041

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Fix iOS 15 crash on remote messaging #2041

merged 4 commits into from
Sep 26, 2023

Conversation

Bunn
Copy link
Contributor

@Bunn Bunn commented Sep 25, 2023

Task/Issue URL: https://app.asana.com/0/414709148257752/1205575729729986/f

Description:
On iOS 15 the Spacer inside the VStack for the closeButtonHeader was causing the app to enter in an infinite loop.

Steps to test this PR:

  1. Follow the steps in the Asana task

Device Testing:

  • iPhone
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • iOS 17

@Bunn
Fix crash related to Spacer
68586f4 
On iOS 15 the Spacer inside the VStack for the closeButtonHeader was causing the app to enter in an infinite loop.
@Bunn Bunn requested a review from jaceklyp September 25, 2023 22:21
samsymons
samsymons requested changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as far as I can see, but I'm marking this as Requested Changes since we should merge develop into this branch and remove the iOS 16 check I added via the hotfix before merging.

@Bunn
Copy link
Contributor Author

Bunn commented Sep 26, 2023

This looks good as far as I can see, but I'm marking this as Requested Changes since we should merge develop into this branch and remove the iOS 16 check I added via the hotfix before merging.

Good call, reverted your hotfix here d314c10

@Bunn Bunn requested a review from samsymons September 26, 2023 09:13
@jaceklyp jaceklyp merged commit 6b5b394 into develop Sep 26, 2023
8 checks passed
@jaceklyp jaceklyp deleted the bunn/fix-messaging-crash branch September 26, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsymons samsymons samsymons requested changes

@jaceklyp jaceklyp jaceklyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bunn @samsymons @jaceklyp