Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL deeplink #2035

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Fix URL deeplink #2035

merged 1 commit into from
Sep 26, 2023

Conversation

Bunn
Copy link
Contributor

@Bunn Bunn commented Sep 24, 2023 •
edited by brindy
Loading

Task/Issue URL: https://app.asana.com/0/414709148257752/1205564554996541/f

Description:
Fix URL deeplink

Steps to test this PR:

  1. See task for steps on how to reproduce the issue
  2. Create a note with multiple types of urls and just queries (for example: https://example.com, http://example.com, www.example.com, example, duck)
  3. Go to each of them, tap and hold, select share, then open in the DDG browser
  4. Check if it’s correctly opening as searches or websites
  • iOS 15
  • iOS 16

@Bunn Bunn requested a review from brindy September 24, 2023 19:42
brindy
brindy approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bunn Bunn merged commit 7691228 into develop Sep 26, 2023
12 checks passed
@Bunn Bunn deleted the bunn/fix-quick-link branch September 26, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bunn @brindy