Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log user out of Sync when SyncOperation receives a HTTP 401 #2031

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Sep 22, 2023

Task/Issue URL: https://app.asana.com/0/1201493110486074/1205552640876379/f

Description:
Log users out also on HTTP 401 received while syncing data.

Steps to test this PR:
See BSK PR for steps to test

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy self-assigned this Sep 22, 2023
@ayoy ayoy requested a review from brindy September 22, 2023 10:20
@ayoy ayoy assigned brindy and unassigned ayoy Sep 22, 2023
@ayoy ayoy marked this pull request as ready for review September 22, 2023 10:20
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brindy brindy assigned ayoy and unassigned brindy Sep 22, 2023
@ayoy ayoy merged commit 6c76d66 into develop Sep 22, 2023
8 checks passed
@ayoy ayoy deleted the dominik/sync-logout-unauthorized-sync-operation branch September 22, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants