Send failed compilations pixel if needed #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaresiak
reviewed
Sep 18, 2023
DuckDuckGo/AppDelegate.swift
Outdated
| let store = FailedCompilationsStore() | ||
| if store.hasAnyFailures { | ||
| DailyPixel.fire(pixel: .compilationFailed, withAdditionalParameters: store.summary) { error in | ||
| if error == nil { |
There was a problem hiding this comment.
nitpick: I'd use guard here :)
jaceklyp
force-pushed
the
jacek/compilation-pixel
branch
from
4d0cef7 to
ff4dd4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203790657351911/1205404596674276/f
Description:
Introduce daily pixel containing information about failed content blocking rules compilations.
Steps to test this PR: