Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 7.88.1 #2001

Merged
merged 3 commits into from
Sep 11, 2023
+4 −4
Merged

Release 7.88.1 #2001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04002f3
Add authentication state check when enabling grace period
amddg44 Sep 11, 2023
40402c4
Update version number
amddg44 Sep 11, 2023
f7bade3
Merge branch 'anya/fix-autofill-auth-issue' into hotfix/7.88.1-changes
amddg44 Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Configuration/Version.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
MARKETING_VERSION = 7.88.0
MARKETING_VERSION = 7.88.1
2 changes: 1 addition & 1 deletion DuckDuckGo/AutofillLoginDetailsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class AutofillLoginDetailsViewController: UIViewController {

override func viewDidAppear(_ animated: Bool) {
super.viewDidAppear(animated)
if !authenticationNotRequired {
if !authenticationNotRequired && authenticator.state == .loggedIn {
authenticator.authenticate()
}
}
Expand Down
2 changes: 1 addition & 1 deletion DuckDuckGo/AutofillLoginSettingsListViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ final class AutofillLoginSettingsListViewController: UIViewController {

override func viewWillDisappear(_ animated: Bool) {
super.viewWillDisappear(animated)
if viewModel.authenticator.canAuthenticate() {
if viewModel.authenticator.canAuthenticate() && viewModel.authenticator.state == .loggedIn {
AppDependencyProvider.shared.autofillLoginSession.startSession()
}
}
Expand Down
2 changes: 1 addition & 1 deletion DuckDuckGo/Settings.bundle/Root.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<array>
<dict>
<key>DefaultValue</key>
<string>7.88.0</string>
<string>7.88.1</string>
<key>Key</key>
<string>version</string>
<key>Title</key>
Expand Down
Loading