Skip to content

Commit

Permalink
Update Delegate Signature (#1939)
Browse files Browse the repository at this point in the history
Task/Issue URL: https://app.asana.com/0/1204099484721401/1202285063304466/f
BSK PR: duckduckgo/BrowserServicesKit#477

Description:
Updates the SecureVaultDelegate signature, so we can individually turn off autofill for cards, logins and identities on macOS (and on iOS later down the road).
  • Loading branch information
afterxleep authored Sep 7, 2023
1 parent 2a4d82b commit ee1262d
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -8878,7 +8878,7 @@
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
requirement = {
kind = exactVersion;
version = 77.1.0;
version = 77.2.0;
};
};
C14882EB27F211A000D59F0C /* XCRemoteSwiftPackageReference "SwiftSoup" */ = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"repositoryURL": "https://github.com/DuckDuckGo/BrowserServicesKit",
"state": {
"branch": null,
"revision": "2b3d31dc3e8b7943a17558e4f9d86145f9ece4dc",
"version": "77.1.0"
"revision": "42b073f8a26165e8b328a5f72501abfecdd4c666",
"version": "77.2.0"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion DuckDuckGo/EmailSignupViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ extension EmailSignupViewController: SecureVaultManagerDelegate {
SecureVaultErrorReporter.shared.secureVaultInitFailed(error)
}

func secureVaultManagerIsEnabledStatus(_: SecureVaultManager) -> Bool {
func secureVaultManagerIsEnabledStatus(_ manager: SecureVaultManager, forType type: AutofillType?) -> Bool {
let isEnabled = AutofillSettingStatus.isAutofillEnabledInSettings && featureFlagger.isFeatureOn(.autofillCredentialInjecting)
return isEnabled
}
Expand Down
2 changes: 1 addition & 1 deletion DuckDuckGo/TabViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2280,7 +2280,7 @@ extension TabViewController: SecureVaultManagerDelegate {
SecureVaultErrorReporter.shared.secureVaultInitFailed(error)
}

func secureVaultManagerIsEnabledStatus(_: SecureVaultManager) -> Bool {
func secureVaultManagerIsEnabledStatus(_ manager: SecureVaultManager, forType type: AutofillType?) -> Bool {
let isEnabled = AutofillSettingStatus.isAutofillEnabledInSettings && featureFlagger.isFeatureOn(.autofillCredentialInjecting)
let isBackgrounded = UIApplication.shared.applicationState == .background
if isEnabled && isBackgrounded {
Expand Down

0 comments on commit ee1262d

Please sign in to comment.