VPN Domain Exclusions pixel changes (#3242)

Task/Issue URL: https://app.asana.com/0/0/1208044141877984/f BSK PR: duckduckgo/BrowserServicesKit#945 macOS PR: duckduckgo/macos-browser#3103 Description Removes a duplicated pixel and updates BSK to include the latest macOS changes.
duckduckgo · Aug 29, 2024 · e736442 · e736442
1 parent aeb6f67
commit e736442
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 11 deletions.
diff --git a/Core/PixelEvent.swift b/Core/PixelEvent.swift
@@ -413,7 +413,6 @@ extension Pixel {
         case networkProtectionFailedToLoadFromPreferences
         case networkProtectionFailedToSaveToPreferences
         case networkProtectionActivationRequestFailed
-        case networkProtectionFailedToStartTunnel
 
         case networkProtectionDisconnected
 
@@ -1181,7 +1180,6 @@ extension Pixel.Event {
         case .networkProtectionFailedToLoadFromPreferences: return "m_netp_network_extension_error_failed_to_load_from_preferences"
         case .networkProtectionFailedToSaveToPreferences: return "m_netp_network_extension_error_failed_to_save_to_preferences"
         case .networkProtectionActivationRequestFailed: return "m_netp_network_extension_error_activation_request_failed"
-        case .networkProtectionFailedToStartTunnel: return "m_netp_failed_to_start_tunnel"
         case .networkProtectionDisconnected: return "m_netp_vpn_disconnect"
         case .networkProtectionNoAccessTokenFoundError: return "m_netp_no_access_token_found_error"
         case .networkProtectionMemoryWarning: return "m_netp_vpn_memory_warning"

diff --git a/PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift b/PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift
@@ -304,15 +304,6 @@ final class NetworkProtectionPacketTunnelProvider: PacketTunnelProvider {
         }
     }
 
-    public override func startTunnel(options: [String: NSObject]?, completionHandler: @escaping (Error?) -> Void) {
-        super.startTunnel(options: options) { error in
-            if error != nil {
-                DailyPixel.fireDailyAndCount(pixel: .networkProtectionFailedToStartTunnel, error: error)
-            }
-            completionHandler(error)
-        }
-    }
-
     public override func stopTunnel(with reason: NEProviderStopReason, completionHandler: @escaping () -> Void) {
         switch reason {
         case .appUpdate, .userInitiated: