-
Notifications
You must be signed in to change notification settings - Fork 424
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix sending pixel when dismissing keyboard on NTP (#3709)
Task/Issue URL: https://app.asana.com/0/1206226850447395/1208763673835126/f Tech Design URL: CC: **Description**: Fixed a few issues with sending pixel while dismissing keyboard with a swipe gesture: 1. Prevented sending pixel twice with a long gesture. 2. Fixed `isDragging` to set when swiping upwards. 3. Prevented stuttering of view while doing the scroll gesture with keyboard present. **Steps to test this PR**: Observe a **single** `m.addressbar.focus.dismiss.gesture` being sent while on a NTP with favorites and: 1. Dismissing keyboard by scrolling up 1. Dismissing keyboard by scrolling down 1. Dismissing keyboard by scrolling continuously up and down **Definition of Done (Internal Only)**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
- Loading branch information
Showing
3 changed files
with
10 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters