Skip to content

Commit

Permalink
remove pixels for keyboard toggle (#3135)
Browse files Browse the repository at this point in the history
  • Loading branch information
brindy authored Jul 25, 2024
1 parent 879d1f4 commit a99b701
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 21 deletions.
11 changes: 0 additions & 11 deletions Core/PixelEvent.swift
Original file line number Diff line number Diff line change
Expand Up @@ -684,12 +684,6 @@ extension Pixel {
case settingsAccessibilityOpen
case settingsAccessiblityTextSize

// Other settings
case settingsKeyboardOnNewTabOn
case settingsKeyboardOnNewTabOff
case settingsKeyboardOnAppLaunchOn
case settingsKeyboardOnAppLaunchOff

// Web pixels
case privacyProOfferMonthlyPriceClick
case privacyProOfferYearlyPriceClick
Expand Down Expand Up @@ -791,11 +785,6 @@ extension Pixel.Event {
case .settingsAutoconsentOn: return "m_settings_autoconsent_on"
case .settingsAutoconsentOff: return "m_settings_autoconsent_off"

case .settingsKeyboardOnNewTabOn: return "m_settings_keyboard_on-new-tab_on"
case .settingsKeyboardOnNewTabOff: return "m_settings_keyboard_on-new-tab_off"
case .settingsKeyboardOnAppLaunchOn: return "m_settings_keyboard_on-app-launch_on"
case .settingsKeyboardOnAppLaunchOff: return "m_settings_keyboard_on-app-launch_off"

case .browsingMenuOpened: return "mb"
case .browsingMenuNewTab: return "mb_tb"
case .browsingMenuAddToBookmarks: return "mb_abk"
Expand Down
10 changes: 0 additions & 10 deletions DuckDuckGo/KeyboardSettingsViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -45,20 +45,10 @@ class KeyboardSettingsViewController: UITableViewController {

@IBAction func onNewTabValueChanged(_ sender: Any) {
settings.onNewTab = newTabToggle.isOn
if settings.onNewTab {
Pixel.fire(pixel: .settingsKeyboardOnNewTabOn)
} else {
Pixel.fire(pixel: .settingsKeyboardOnNewTabOff)
}
}

@IBAction func onAppLaunchValueChanged(_ sender: Any) {
settings.onAppLaunch = appLaunchToggle.isOn
if settings.onAppLaunch {
Pixel.fire(pixel: .settingsKeyboardOnAppLaunchOn)
} else {
Pixel.fire(pixel: .settingsKeyboardOnAppLaunchOff)
}
}

}
Expand Down

0 comments on commit a99b701

Please sign in to comment.