Skip to content

Commit

Permalink
Update hardcoded copy.
Browse files Browse the repository at this point in the history
  • Loading branch information
samsymons committed Nov 15, 2023
1 parent 5b15a12 commit 9149b5c
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 82 deletions.

This file was deleted.

This file was deleted.

7 changes: 6 additions & 1 deletion DuckDuckGo/UserText.swift
Original file line number Diff line number Diff line change
Expand Up @@ -874,7 +874,7 @@ In addition to the details entered into this form, your app issue report will co

// MARK: - VPN Waitlist

static let networkProtectionWaitlistJoinTitle = NSLocalizedString("network-protection.waitlist.join.title", value: "Network Protection Beta", comment: "Title for Network Protection join waitlist screen")
static let networkProtectionWaitlistJoinTitle = NSLocalizedString("network-protection.waitlist.join.title", value: "Network Protection Early Access", comment: "Title for Network Protection join waitlist screen")
static let networkProtectionWaitlistJoinSubtitle1 = NSLocalizedString("network-protection.waitlist.join.subtitle.1", value: "Secure your connection anytime, anywhere with Network Protection, the VPN from DuckDuckGo.", comment: "First subtitle for Network Protection join waitlist screen")
static let networkProtectionWaitlistJoinSubtitle2 = NSLocalizedString("network-protection.waitlist.join.subtitle.2", value: "Join the waitlist, and we’ll notify you when it’s your turn.", comment: "Second subtitle for Network Protection join waitlist screen")

Expand Down Expand Up @@ -905,4 +905,9 @@ In addition to the details entered into this form, your app issue report will co

static let networkProtectionPrivacyPolicyTitle = NSLocalizedString("network-protection.privacy-policy.title", value: "Privacy Policy", comment: "Privacy Policy title for Network Protection")

static let networkProtectionWaitlistNotificationAlertDescription = NSLocalizedString("network-protection.waitlist.notification-alert.description", value: "We’ll send you a notification when your invite to test Network Protection is ready.", comment: "Body text for the alert to enable notifications")

static let networkProtectionWaitlistGetStarted = NSLocalizedString("network-protection.waitlist.get-started", value: "Get Started", comment: "Button title text for the Network Protection waitlist confirmation prompt")
static let networkProtectionWaitlistAgreeAndContinue = NSLocalizedString("network-protection.waitlist.agree-and-continue", value: "Agree and Continue", comment: "Title text for the Network Protection terms and conditions accept button")

}
4 changes: 2 additions & 2 deletions DuckDuckGo/VPNWaitlistView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ struct VPNWaitlistInvitedView: View {
}
.padding(.top, 24)

Button("Get Started", action: { action(.custom(.openNetworkProtectionPrivacyPolicyScreen)) })
Button(UserText.networkProtectionWaitlistGetStarted, action: { action(.custom(.openNetworkProtectionPrivacyPolicyScreen)) })
.buttonStyle(RoundedButtonStyle(enabled: true))
.padding(.top, 32)

Expand Down Expand Up @@ -322,7 +322,7 @@ struct VPNWaitlistPrivacyPolicyView: View {
Text(VPNWaitlistUserText.networkProtectionTermsOfServiceSection8List).bodyStyle()
}

Button("Agree and Continue", action: { action(.custom(.acceptNetworkProtectionTerms)) })
Button(UserText.networkProtectionWaitlistAgreeAndContinue, action: { action(.custom(.acceptNetworkProtectionTerms)) })
.buttonStyle(RoundedButtonStyle(enabled: true))
.padding(.top, 24)
}
Expand Down
4 changes: 2 additions & 2 deletions DuckDuckGo/VPNWaitlistViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ final class VPNWaitlistViewController: UIViewController {
override func viewDidLoad() {
super.viewDidLoad()

title = "Network Protection Preview"
title = UserText.networkProtectionWaitlistJoinTitle

addHostingControllerToViewHierarchy()

Expand Down Expand Up @@ -96,7 +96,7 @@ extension VPNWaitlistViewController: WaitlistViewModelDelegate {
func waitlistViewModelDidAskToReceiveJoinedNotification(_ viewModel: WaitlistViewModel) async -> Bool {
return await withCheckedContinuation { continuation in
let alertController = UIAlertController(title: UserText.waitlistNotifyMeConfirmationTitle,
message: "We’ll send you a notification when your invite to test Network Protection is ready.",
message: UserText.networkProtectionWaitlistNotificationAlertDescription,
preferredStyle: .alert)
alertController.overrideUserInterfaceStyle()

Expand Down
11 changes: 10 additions & 1 deletion DuckDuckGo/en.lproj/Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -1435,6 +1435,9 @@ https://duckduckgo.com/mac";
/* Privacy Policy title for Network Protection */
"network-protection.privacy-policy.title" = "Privacy Policy";

/* Title text for the Network Protection terms and conditions accept button */
"network-protection.waitlist.agree-and-continue" = "Agree and Continue";

/* Availability disclaimer for Network Protection join waitlist screen */
"network-protection.waitlist.availability-disclaimer" = "Network Protection is free to use during the beta.";

Expand All @@ -1447,6 +1450,9 @@ https://duckduckgo.com/mac";
/* Join Waitlist button for Network Protection join waitlist screen */
"network-protection.waitlist.button.join-waitlist" = "Join the Waitlist";

/* Button title text for the Network Protection waitlist confirmation prompt */
"network-protection.waitlist.get-started" = "Get Started";

/* Subtitle for section 1 of the Network Protection invited screen */
"network-protection.waitlist.invited.section-1.subtitle" = "Encrypt online traffic across your browsers and apps.";

Expand Down Expand Up @@ -1478,7 +1484,7 @@ https://duckduckgo.com/mac";
"network-protection.waitlist.join.subtitle.2" = "Join the waitlist, and we’ll notify you when it’s your turn.";

/* Title for Network Protection join waitlist screen */
"network-protection.waitlist.join.title" = "Network Protection Beta";
"network-protection.waitlist.join.title" = "Network Protection Early Access";

/* Title for Network Protection joined waitlist screen */
"network-protection.waitlist.joined.title" = "You’re on the list!";
Expand All @@ -1489,6 +1495,9 @@ https://duckduckgo.com/mac";
/* Subtitle 2 for Network Protection joined waitlist screen when notifications are enabled */
"network-protection.waitlist.joined.with-notifications.subtitle.2" = "We’ll notify you when your invite is ready.";

/* Body text for the alert to enable notifications */
"network-protection.waitlist.notification-alert.description" = "We’ll send you a notification when your invite to test Network Protection is ready.";

/* Title for Network Protection waitlist notification */
"network-protection.waitlist.notification.text" = "Open your invite";

Expand Down

0 comments on commit 9149b5c

Please sign in to comment.