Skip to content

Commit

Permalink
remove set as default statistics (#2018)
Browse files Browse the repository at this point in the history
  • Loading branch information
brindy authored Sep 19, 2023
1 parent 50463f5 commit 8f256c3
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 80 deletions.
2 changes: 0 additions & 2 deletions Core/Pixel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,6 @@ public struct PixelParameters {
public static let message = "message"
public static let sheetResult = "success"

public static let defaultBrowser = "default_browser"

// Return user
public static let returnUserErrorCode = "error_code"
public static let returnUserOldATB = "old_atb"
Expand Down
12 changes: 0 additions & 12 deletions Core/PixelEvent.swift
Original file line number Diff line number Diff line change
Expand Up @@ -302,10 +302,6 @@ extension Pixel {
case remoteMessageSecondaryActionClicked
case remoteMessageSheet

// MARK: Set as Default
case onboardingSetDefaultOpened
case onboardingSetDefaultSkipped

// MARK: Return user measurement
case returnUser

Expand Down Expand Up @@ -443,8 +439,6 @@ extension Pixel {

case invalidPayload(Configuration)

case dailyActiveUser

case emailIncontextPromptDisplayed
case emailIncontextPromptConfirmed
case emailIncontextPromptDismissed
Expand Down Expand Up @@ -744,10 +738,6 @@ extension Pixel.Event {
case .remoteMessageSecondaryActionClicked: return "m_remote_message_secondary_action_clicked"
case .remoteMessageSheet: return "m_remote_message_sheet"

// MARK: Set as default measuring
case .onboardingSetDefaultOpened: return "m_onboarding_set-default-opened"
case .onboardingSetDefaultSkipped: return "m_onboarding_set-default-skipped"

// MARK: debug pixels

case .dbCrashDetected: return "m_d_crash"
Expand Down Expand Up @@ -880,8 +870,6 @@ extension Pixel.Event {

case .invalidPayload(let configuration): return "m_d_\(configuration.rawValue)_invalid_payload".lowercased()

case .dailyActiveUser: return "m_daily_active_user"

// MARK: - InContext Email Protection
case .emailIncontextPromptDisplayed: return "m_email_incontext_prompt_displayed"
case .emailIncontextPromptConfirmed: return "m_email_incontext_prompt_confirmed"
Expand Down
55 changes: 0 additions & 55 deletions Core/SetAsDefaultStatistics.swift

This file was deleted.

4 changes: 0 additions & 4 deletions Core/StatisticsLoader.swift
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,6 @@ public class StatisticsLoader {
return
}

SetAsDefaultStatistics().fireDailyActiveUser()

let configuration = APIRequest.Configuration(url: url)
let request = APIRequest(configuration: configuration, urlSession: .session())

Expand All @@ -116,8 +114,6 @@ public class StatisticsLoader {
return
}

SetAsDefaultStatistics().fireDailyActiveUser()

let configuration = APIRequest.Configuration(url: url)
let request = APIRequest(configuration: configuration, urlSession: .session())

Expand Down
4 changes: 0 additions & 4 deletions DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,6 @@
8565A34B1FC8D96B00239327 /* LaunchTabNotification.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8565A34A1FC8D96B00239327 /* LaunchTabNotification.swift */; };
8565A34D1FC8DFE400239327 /* LaunchTabNotificationTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8565A34C1FC8DFE400239327 /* LaunchTabNotificationTests.swift */; };
8577A1C5255D2C0D00D43FCD /* HitTestingToolbar.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8577A1C4255D2C0D00D43FCD /* HitTestingToolbar.swift */; };
8577C6602A964BAC00788B3A /* SetAsDefaultStatistics.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8577C65F2A964BAC00788B3A /* SetAsDefaultStatistics.swift */; };
857EEB752095FFAC008A005C /* HomeRowInstructionsViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 857EEB742095FFAC008A005C /* HomeRowInstructionsViewController.swift */; };
858566E8252E4F56007501B8 /* Debug.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 858566E7252E4F56007501B8 /* Debug.storyboard */; };
858566FB252E55D6007501B8 /* ImageCacheDebugViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 858566FA252E55D6007501B8 /* ImageCacheDebugViewController.swift */; };
Expand Down Expand Up @@ -1403,7 +1402,6 @@
8565A34A1FC8D96B00239327 /* LaunchTabNotification.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LaunchTabNotification.swift; sourceTree = "<group>"; };
8565A34C1FC8DFE400239327 /* LaunchTabNotificationTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LaunchTabNotificationTests.swift; sourceTree = "<group>"; };
8577A1C4255D2C0D00D43FCD /* HitTestingToolbar.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = HitTestingToolbar.swift; sourceTree = "<group>"; };
8577C65F2A964BAC00788B3A /* SetAsDefaultStatistics.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SetAsDefaultStatistics.swift; sourceTree = "<group>"; };
857EEB742095FFAC008A005C /* HomeRowInstructionsViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = HomeRowInstructionsViewController.swift; sourceTree = "<group>"; };
858566E7252E4F56007501B8 /* Debug.storyboard */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; path = Debug.storyboard; sourceTree = "<group>"; };
858566FA252E55D6007501B8 /* ImageCacheDebugViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ImageCacheDebugViewController.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -4400,7 +4398,6 @@
853A717520F62FE800FE60BC /* Pixel.swift */,
1E05D1D729C46EDA00BF9A1F /* TimedPixel.swift */,
1E05D1D529C46EBB00BF9A1F /* DailyPixel.swift */,
8577C65F2A964BAC00788B3A /* SetAsDefaultStatistics.swift */,
85E242162AB1B54D000F3E28 /* ReturnUserMeasurement.swift */,
);
name = Statistics;
Expand Down Expand Up @@ -6642,7 +6639,6 @@
85F21DC621145DD5002631A6 /* global.swift in Sources */,
F41C2DA326C1925700F9A760 /* BookmarksAndFolders.xcdatamodeld in Sources */,
F4F6DFBA26EFF28A00ED7E12 /* BookmarkObjects.swift in Sources */,
8577C6602A964BAC00788B3A /* SetAsDefaultStatistics.swift in Sources */,
836A941D247F23C600BF8EF5 /* UserAgentManager.swift in Sources */,
4B83397329AFB8D2003F7EA9 /* AppTrackingProtectionFeedbackModel.swift in Sources */,
85CA53A824BB343700A6288C /* Favicons.swift in Sources */,
Expand Down
1 change: 0 additions & 1 deletion DuckDuckGo/AppDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,6 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
showKeyboardIfSettingOn = false

if !handleAppDeepLink(app, mainViewController, url) {
SetAsDefaultStatistics().openedAsDefault()
mainViewController?.loadUrlInNewTab(url, reuseExisting: true, inheritedAttribution: nil)
}

Expand Down
2 changes: 0 additions & 2 deletions DuckDuckGo/OnboardingDefaultBroswerViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,13 @@ class OnboardingDefaultBroswerViewController: OnboardingContentViewController {
}

override func onContinuePressed(navigationHandler: @escaping () -> Void) {
SetAsDefaultStatistics().setAsDefaultOpened()
if let url = URL(string: UIApplication.openSettingsURLString) {
UIApplication.shared.open(url)
}
super.onContinuePressed(navigationHandler: navigationHandler)
}

override func onSkipPressed(navigationHandler: @escaping () -> Void) {
SetAsDefaultStatistics().setAsDefaultSkipped()
super.onSkipPressed(navigationHandler: navigationHandler)
}
}

0 comments on commit 8f256c3

Please sign in to comment.